Merged
Conversation
tqchen
reviewed
Jun 27, 2021
tqchen
requested changes
Jun 28, 2021
tqchen
reviewed
Jun 28, 2021
tqchen
reviewed
Jun 28, 2021
tqchen
reviewed
Jun 28, 2021
tqchen
requested changes
Jun 28, 2021
tqchen
reviewed
Jun 28, 2021
tqchen
reviewed
Jun 28, 2021
tqchen
reviewed
Jun 28, 2021
Member
|
cc @vinx13 @junrushao1994 please help to take a look |
tqchen
reviewed
Jun 28, 2021
comaniac
reviewed
Jun 28, 2021
Contributor
comaniac
left a comment
There was a problem hiding this comment.
The logic LGTM. One miner point: is it possible to work on param_map directly instead of one-by-one? Specifically, can we build var mapping in Specialize with several parameters so that we can run PrimFuncSpecializer::Specialize just once and make the time complexity decouple to the parameter number?
Member
Author
|
Thanks, @comaniac. Just have fixed it |
tqchen
requested changes
Jun 30, 2021
added 3 commits
June 30, 2021 16:25
tqchen
approved these changes
Jul 1, 2021
Comment on lines
+189
to
+191
| def test_specialize_recursive_load(): | ||
| # TODO(Siyuan): add recursive Load testcase, e.g. A[C[i]] | ||
| pass |
Contributor
There was a problem hiding this comment.
I saw this TODO item today. Is it intended to leave the TODO here? Or it was because we forgot to write the unittest?
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables meta_programming for TVM Functions (usually used for TVMScript), which is useful to define only one function(TVMScript) but used in different shapes.
Example:
Mate fucntion
Instruction:
Specialized function:
cc @tqchen @junrushao1994 @MasterJH5574 @comaniac