FoldScaleAxis became non-recursive#8325
Merged
mbrookhart merged 2 commits intoapache:mainfrom Jul 15, 2021
Merged
Conversation
FoldScaleAxis moved from ExprVisitor and ExprMutator to non-recursive MixedModeVisitor and MixedModeMutator. The specific transforming part itself is still recursive, however the underlying traversal machinery is non-recursive. Change-Id: I8bf40bd1f3f039ef0705c665a34a4624067048a1
Contributor
Author
Contributor
Author
|
bump. also cc @tqchen |
Contributor
|
Sorry! Not sure how I lost this. I don't fully understand this pass, and it seems you've made some more complicated changes above moving it to mixed mode? I would appriciate @tqchen's review, since it was originally his code. |
Member
|
Would be great if @vinx13 can also help to take a look |
Contributor
Author
There is an extra minor change related to not doing the optimization if there were no messages produced by preparation sub-passes. |
Contributor
Author
|
bump |
mbrookhart
reviewed
Jul 8, 2021
Contributor
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
I'm happy with the mixed mode parts, but I'd still love to get @vinx13's eyes on it.
vinx13
approved these changes
Jul 8, 2021
Member
|
@d-smirnov There are some irrelevant errors on CI, Could you try again to get CI passed? Thanks |
Change-Id: I242ec95f92b3dfc7fa3dd89385f56ab07c6e72a8
d-smirnov
force-pushed
the
fold_scale_axis
branch
from
5f0bc5d to
383c2a1
Compare
Contributor
|
Thanks @d-smirnov @vinx13 @tqchen |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* FoldScaleAxis became non-recursive FoldScaleAxis moved from ExprVisitor and ExprMutator to non-recursive MixedModeVisitor and MixedModeMutator. The specific transforming part itself is still recursive, however the underlying traversal machinery is non-recursive. Change-Id: I8bf40bd1f3f039ef0705c665a34a4624067048a1 * Added extra empty lines as requested Change-Id: I242ec95f92b3dfc7fa3dd89385f56ab07c6e72a8
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
* FoldScaleAxis became non-recursive FoldScaleAxis moved from ExprVisitor and ExprMutator to non-recursive MixedModeVisitor and MixedModeMutator. The specific transforming part itself is still recursive, however the underlying traversal machinery is non-recursive. Change-Id: I8bf40bd1f3f039ef0705c665a34a4624067048a1 * Added extra empty lines as requested Change-Id: I242ec95f92b3dfc7fa3dd89385f56ab07c6e72a8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates FoldScaleAxis optimization pass from ExprVisitor/ExprMutator to non-recursive MixedModeVisitor/MixedModeMutator. The specific transforming part itself is still recursive, however the underlying traversal machinery is now non-recursive.