[OpenCL] Add check to only cast opaque handles to cl::BufferDescriptor at runtime#8256
Merged
masahi merged 1 commit intoapache:mainfrom Jun 15, 2021
csullivan:opencl_kernel_arg_fix
Merged
[OpenCL] Add check to only cast opaque handles to cl::BufferDescriptor at runtime#8256masahi merged 1 commit intoapache:mainfrom csullivan:opencl_kernel_arg_fix
masahi merged 1 commit intoapache:mainfrom
csullivan:opencl_kernel_arg_fix
Conversation
Contributor
Author
|
cc @masahi |
masahi
approved these changes
Jun 15, 2021
Member
masahi
left a comment
masahi
left a comment
There was a problem hiding this comment.
I confirmed that this fixes the segfault on my object detection model, thanks for the quick fix @csullivan
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous casting of void_args was too aggressive and attempted to cast non backend allocated handles, such as kernel scalar arguments, to cl::BufferDescriptors.