[µTVM] Zephyr: Fix missing board-specific config file in build dir#8230
Merged
masahi merged 1 commit intoapache:mainfrom Jun 11, 2021
Merged
[µTVM] Zephyr: Fix missing board-specific config file in build dir#8230masahi merged 1 commit intoapache:mainfrom
masahi merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
@areusch Hi! Any clue if the CI error is legit or not? Seems quite unrelated to my change. I don't have a GPU to try it out locally unfortunately so I'll need a hand to figure it out : ) |
Contributor
|
thanks @gromero , hopefully Project API will obviate this change since we'll just be using a single project, but let's merge in the meantime. unfortunately the CI error looks unrelated/flaky, can you just push an empty commit or git commit --amend to retrigger? |
areusch
approved these changes
Jun 10, 2021
Currently board-specific config files (boards/*.conf) are not copied from Zephyr project dir to the destination build dir, so as a consequence the per board configs are not used when building the runtime libraries, like libcommon. Hence, for instance, it's currently not possible to set CONFIG_FPU per board since it only takes effect when it's set in the generic 'prj.con' config file. This commit fixes it by copying to the build dir (to each lib dir) the proper .conf for the selected target board. For example, if target 'qemu_x86' is selected 'qemu_x86.conf' is copied to the boards/ dir inside the lib dirs, so Zephyr build system can find it and combine it with configs found in the generic 'prj.conf'. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
bc2e617 to
4c37f54
Compare
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8230) Currently board-specific config files (boards/*.conf) are not copied from Zephyr project dir to the destination build dir, so as a consequence the per board configs are not used when building the runtime libraries, like libcommon. Hence, for instance, it's currently not possible to set CONFIG_FPU per board since it only takes effect when it's set in the generic 'prj.con' config file. This commit fixes it by copying to the build dir (to each lib dir) the proper .conf for the selected target board. For example, if target 'qemu_x86' is selected 'qemu_x86.conf' is copied to the boards/ dir inside the lib dirs, so Zephyr build system can find it and combine it with configs found in the generic 'prj.conf'. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8230) Currently board-specific config files (boards/*.conf) are not copied from Zephyr project dir to the destination build dir, so as a consequence the per board configs are not used when building the runtime libraries, like libcommon. Hence, for instance, it's currently not possible to set CONFIG_FPU per board since it only takes effect when it's set in the generic 'prj.con' config file. This commit fixes it by copying to the build dir (to each lib dir) the proper .conf for the selected target board. For example, if target 'qemu_x86' is selected 'qemu_x86.conf' is copied to the boards/ dir inside the lib dirs, so Zephyr build system can find it and combine it with configs found in the generic 'prj.conf'. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Could the following small change be reviewed please?
It's necessary to make the build of the libraries (
common,utvm_rpc_common,utvm_rpc_server, etc) be aware of board-specific config settings, like per boardCONFIG_FPU(since some boards, like mps2, don't have a FPU and currently it's set globally inprj.conf). It's also necessary to move forward the following PR:#8055
Without that change, for instance, even if
CONFIG_FPU=yis set in the board config file (likeboards/qemu_x86.conf) the libraries are built against soft-float becauseCONFIG_FPU=ydoesn't take effect and so running some models that rely on float point will fail.This happens because currently board-specific config files (boards/*.conf) are not
copied from Zephyr project dir to the destination build dir, so
as a consequence the per board configs are not used when building
the runtime libraries, like libcommon. Hence, for instance, it's
currently not possible to set CONFIG_FPU per board since it only
takes effect when it's set in the generic 'prj.con' config file.
This commit fixes it by copying to the build dir, to each lib
dir, the proper .conf for the selected target board. For example,
if target 'qemu_x86' is selected 'qemu_x86.conf' is copied to
the boards/ dir inside the lib dirs, so Zephyr build system can
find it and combine it with configs found in the generic 'prj.conf'.
Thanks & best regards,
Gustavo