[ONNX] QLinearConv Support#8007
Merged
mbrookhart merged 4 commits intoapache:mainfrom May 13, 2021
huochaitiantang:qlinear
Merged
[ONNX] QLinearConv Support#8007mbrookhart merged 4 commits intoapache:mainfrom huochaitiantang:qlinear
mbrookhart merged 4 commits intoapache:mainfrom
huochaitiantang:qlinear
Conversation
mbrookhart
reviewed
May 10, 2021
Contributor
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
Looks like it needs a rebase? I'm not sure I understand the issue with the onnx tests, is that something we can work around?
Comment on lines
+4231
to
+4232
| # For QLinearConv tests in ONNX, scale and zero_point input are placeholders, | ||
| # but qnn.conv2d requires scale and zero_point input to be scalar |
Contributor
There was a problem hiding this comment.
Can you explain this comment more?
Contributor
Author
There was a problem hiding this comment.
I have tried to work around this issue but failed. For ONNX test model of QLinearConv, y_scale is input node and will be parsed to free_var in relay. It will cause an error while lowering requantize because it requires output_scale (y_scale) to be constant expr:
E 1: tvm::relay::qnn::RequantizeLower(tvm::RelayExpr const&, tvm::RelayExpr const&, tvm::RelayExpr const&, tvm::RelayExpr const&, tvm::RelayExpr const&, tvm::relay::qnn::RequantizeAttrs const*, tvm::r
untime::Array<tvm::PrimExpr, void> const&, tvm::runtime::DataType const&)
E at /home/liuliang/Desktop/tvms/tvm/src/relay/qnn/op/requantize.cc:148
E 0: float tvm::relay::GetScalarFromConstant<float>(tvm::RelayExpr)
E at /home/liuliang/Desktop/tvms/tvm/src/relay/qnn/op/../../transforms/pattern_utils.h:514
E File "/home/liuliang/Desktop/tvms/tvm/src/relay/quantize/../transforms/pattern_utils.h", line 514
E TVMError:
E ---------------------------------------------------------------
E An error occurred during the execution of TVM.
E For more information, please see: https://tvm.apache.org/docs/errors.html
E ---------------------------------------------------------------
E Check failed: (n) is false: Expr must be a constant expr - #[version = "0.0.5"]
E free_var %y_scale: float32;
E cast(%y_scale, dtype="float32") /* ty=float32 */
Do you have some suggestions to solve it?
Contributor
|
Hmm, what do you think about checking to see if the scale is constant, and if it's not, doing dequantize -> quantize instead of requantize? |
Contributor
Author
|
@mbrookhart, thanks! The idea looks good, it could solve the issue! |
mbrookhart
approved these changes
May 12, 2021
Contributor
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
LGTM. Looks like we had a CI outage, can you rebase to kick off a new job?
Contributor
|
Thanks @huochaitiantang ! |
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
May 19, 2021
* Add QLinearConv for onnx frontend * Reformat * Squeeze 1D tensor for weight_scale & weight_zero_point * Doing dequatize -> quantize if y_scale is not constant
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
* Add QLinearConv for onnx frontend * Reformat * Squeeze 1D tensor for weight_scale & weight_zero_point * Doing dequatize -> quantize if y_scale is not constant
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
* Add QLinearConv for onnx frontend * Reformat * Squeeze 1D tensor for weight_scale & weight_zero_point * Doing dequatize -> quantize if y_scale is not constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.