[TensorIR][PASS][M1c] PlanUpdateBufferAllocationLocation#7873
Merged
junrushao merged 1 commit intoapache:mainfrom Apr 19, 2021
Merged
[TensorIR][PASS][M1c] PlanUpdateBufferAllocationLocation#7873junrushao merged 1 commit intoapache:mainfrom
junrushao merged 1 commit intoapache:mainfrom
Conversation
Member
|
Shall we find a shorter name this this pass 😆 |
junrushao
requested changes
Apr 18, 2021
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Shall we find a short name for this pass? What about RealizeBufferAlloc?
29 tasks
Hzfengsy
force-pushed
the
main
branch
2 times, most recently
from
beab57d to
b93f63f
Compare
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
jcf94
reviewed
Apr 19, 2021
Comment on lines
+48
to
+52
| for i_0 in range(0, 16): | ||
| with tir.block([]): | ||
| tir.reads([A[i_0, 0:16]]) | ||
| tir.writes([C[i_0, 0:16]]) | ||
| B = tir.alloc_buffer([16, 16]) |
Contributor
There was a problem hiding this comment.
Does this test case means that the buffer defined outside this block(the original element_func) will be transformed to a buffer inside the block?
What if the for i_0 in range(0, 16) is a axis with parallel, this will turns a thread common buffer to a thread local buffer?
Member
There was a problem hiding this comment.
@jcf94 i believe your understanding is correct in this case
Member
|
The current naming is fine given it is a pass only used internally. Realize may also may not best describe it, as this pass |
junrushao
approved these changes
Apr 19, 2021
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Just chatted with TQ but either of us found no better name... :-(
So let's just stick to PlanUpdateBufferAllocationLocation then...
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 22, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
echuraev
pushed a commit
to echuraev/tvm
that referenced
this pull request
Apr 29, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the TensorIR upstreaming effort (#7527) as one of the M1c stages, introducing the pass PlanUpdateBufferAllocationLocation.
This Pass will Locate the buffer allocation to the exact position (usually is the lca of buffer access) and inject opaque block
with alloc_buffers to annotate the buffer allocation site.
cc @tqchen @comaniac @jroesch @junrushao1994