Merged
Conversation
tqchen
reviewed
Mar 5, 2021
| } | ||
|
|
||
| virtual void SaveToBinary(dmlc::Stream* stream) { | ||
| void SaveToBinary(dmlc::Stream* stream) override { |
tqchen
requested changes
Mar 6, 2021
| } | ||
|
|
||
| const char* type_key() const { return "json"; } | ||
| const char* type_key() const override { return "json"; } |
Member
There was a problem hiding this comment.
should also be final as well, do it to other places that overrides
Contributor
Author
There was a problem hiding this comment.
Actually, arm compute lib inherits from this class. I'm leaving everything as override.
tkonolige
force-pushed
the
clang_warning_fixes
branch
from
fee84a8 to
c154301
Compare
tqchen
approved these changes
Mar 9, 2021
junrushao
added
status: accepted
and removed
status: need update
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixes include
override@junrushao1994 @jroesch @areusch @rohanmukh