[Relay][Frontend][Onnx] Refactor where importer to support dynamic shapes.#7394
Merged
mbrookhart merged 2 commits intoapache:mainfrom Feb 5, 2021
Merged
[Relay][Frontend][Onnx] Refactor where importer to support dynamic shapes.#7394mbrookhart merged 2 commits intoapache:mainfrom
mbrookhart merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@soiferj can you take a look at this PR? |
mbrookhart
reviewed
Feb 2, 2021
Contributor
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
Overall LGTM. Any chance we can add a test where one of the inputs actually has dynamic shapes?
Contributor
Author
|
I would definitely like to but wasn't sure what the right way to force dynamic shapes in a model is. I think we would need to compose a composite graph of some dynamic op followed by where, which might be a very ugly test. Do you know a better way to do that? |
Contributor
|
My goto has been do throw in a |
mbrookhart
approved these changes
Feb 5, 2021
Contributor
|
Thanks @jwfromm |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
…apes. (apache#7394) * Refactor where importer to support dynamic shapes. * Add a test for dynamic where.
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
…apes. (apache#7394) * Refactor where importer to support dynamic shapes. * Add a test for dynamic where.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
…apes. (apache#7394) * Refactor where importer to support dynamic shapes. * Add a test for dynamic where.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
Wherein our importer uses static shape analysis to do broadcasting. Unfortunately, this can break when inputs have dynamic shapes. This PR refactors the analysis to instead support dynamism.