[TEST] Another attempt to fix flaky segfaults from torch detection test #7371
Merged
tqchen merged 1 commit intoapache:mainfrom Feb 1, 2021
Merged
[TEST] Another attempt to fix flaky segfaults from torch detection test #7371tqchen merged 1 commit intoapache:mainfrom
tqchen merged 1 commit intoapache:mainfrom
Conversation
masahi
force-pushed
the
torch-more-disable
branch
from
679d5c7 to
7179997
Compare
tqchen
approved these changes
Feb 1, 2021
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7363. The change in #7365 didn't seem to fix the segfaults, so this is the other alternative for fix. I cannot reproduce this problem locally but it is quite frequent at the post-merge CI https://ci.tlcpack.ai/job/tvm/job/main/ (but not on CIs for open PRs, for some reason)
I restored the disabled rewrite in #7365 and disable the other one. I can also disable both of them, to completely nuke changes from #7346 in the test.
@tqchen @zhiics