[BYOC][Verilator] change runtime registry function name#7351
Merged
tmoreau89 merged 3 commits intoapache:mainfrom Jan 29, 2021
Merged
[BYOC][Verilator] change runtime registry function name#7351tmoreau89 merged 3 commits intoapache:mainfrom
tmoreau89 merged 3 commits intoapache:mainfrom
Conversation
tmoreau89
approved these changes
Jan 27, 2021
Contributor
tmoreau89
left a comment
tmoreau89
left a comment
There was a problem hiding this comment.
LGTM
Is this something a linter can catch?
Member
Author
|
I don't think so, It is just that "name change" |
Contributor
|
Thank you @vegaluisjose the PR was merged. |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* use lowercase for verilator runtime registry function * lint fix * update comment
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* use lowercase for verilator runtime registry function * lint fix * update comment
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* use lowercase for verilator runtime registry function * lint fix * update comment
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* use lowercase for verilator runtime registry function * lint fix * update comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think snake case is more common throughout the codebase than camel case for registering functions
@tmoreau89 @liangfu