[Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.#7208
Merged
masahi merged 1 commit intoapache:mainfrom Jan 5, 2021
Merged
[Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.#7208masahi merged 1 commit intoapache:mainfrom
masahi merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
@luyaor @mbrookhart @masahi can you guys take a look at this tiny PR? |
This was referenced Jan 5, 2021
Contributor
|
Hi @jwfromm @mbrookhart , thanks for the response and effort on this case. The PR looks good to me. I am currently working on a research project related to TVM, would like to make more contributions to TVM and also looking forward to the feedback from community. |
Contributor
Author
|
These two errors that you generated were excellent real bugs with the importer and were very easy to understand and replicate with your post. If they're being auto-generated they look excellent! |
Member
|
Hi @luyaor you are welcome to poke at pytorch frontend too, I hope it is more robust than onnx frontend :) |
tkonolige
pushed a commit
to tkonolige/incubator-tvm
that referenced
this pull request
Jan 11, 2021
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jan 14, 2021
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current prelu converter assumes that incoming data is in NCHW format and that the slope will have C total elements. Neither of these are actual requirements for ONNX PreLu. As pointed out in #7202, our converter fails in other cases. This PR makes our importer prelu compliant with the onnx spec.