Skip to content

[ETHOSN] Add support for default Ethos-N78 configuration.#6982

Merged
mbaret merged 1 commit intoapache:mainfrom
tristan-arm:main
Feb 17, 2021
Merged

[ETHOSN] Add support for default Ethos-N78 configuration.#6982
mbaret merged 1 commit intoapache:mainfrom
tristan-arm:main

Conversation

@tristan-arm
Copy link
Copy Markdown
Contributor

Note: 'ETHOSN_VARIANT_CONFIG' must be set to test against Ethos-N78 and this adds support for one configuration of Ethos-N78 in TVM.

@tristan-arm
Copy link
Copy Markdown
Contributor Author

cc @Leo-arm @u99127 @mbaret

Copy link
Copy Markdown

@u99127 u99127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ethos-N78 comes in multiple configurations and what we have added here is one variant of this.

We need to rethink about what this means with SHA1s for the various configurations that we will add and consider that when we do the next set of configurations.

Some minor nits that I have observed here.

Comment thread src/relay/backend/contrib/ethosn/capabilities.h Outdated
Comment thread tests/scripts/task_python_integration.sh Outdated
Copy link
Copy Markdown

@u99127 u99127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Contributor

@leo-blonk leo-blonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit.

Comment thread src/relay/backend/contrib/ethosn/capabilities.h Outdated
Note: 'ETHOSN_VARIANT_CONFIG' must be set to test against Ethos-N78 and this adds support for one configuration of Ethos-N78 in TVM.
@tristan-arm
Copy link
Copy Markdown
Contributor Author

@mbaret can you review this when you get a chance - thanks

Comment thread tests/python/contrib/test_ethosn/test_networks.py
Copy link
Copy Markdown
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbaret mbaret merged commit 76647ca into apache:main Feb 17, 2021
@mbaret
Copy link
Copy Markdown
Contributor

mbaret commented Feb 17, 2021

Thanks @tristan-arm @u99127 @Leo-arm

Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
Note: 'ETHOSN_VARIANT_CONFIG' must be set to test against Ethos-N78 and this adds support for one configuration of Ethos-N78 in TVM.
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
Note: 'ETHOSN_VARIANT_CONFIG' must be set to test against Ethos-N78 and this adds support for one configuration of Ethos-N78 in TVM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants