[TOPI] Enable scatter_add on GPU #6856
Merged
zhiics merged 5 commits intoapache:mainfrom Nov 5, 2020
Merged
Conversation
mbrookhart
approved these changes
Nov 5, 2020
Contributor
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
LGTM. Good idea on the update func. Maybe we could simplify the cpu kernels with a similar trick.
tqchen
approved these changes
Nov 5, 2020
zhiics
approved these changes
Nov 5, 2020
Member
|
Thanks @masahi @mbrookhart @tqchen |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* enable scatter gpu test on cuda * adding update_func arg * pytorch scatter_add gpu tests working * update 3d and 4d scatter * enable scatter_add gpu test Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* enable scatter gpu test on cuda * adding update_func arg * pytorch scatter_add gpu tests working * update 3d and 4d scatter * enable scatter_add gpu test Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* enable scatter gpu test on cuda * adding update_func arg * pytorch scatter_add gpu tests working * update 3d and 4d scatter * enable scatter_add gpu test Co-authored-by: masa <masa@pop-os.localdomain>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for running
scatter_addop on GPU, building on #6533Hand written IRs developed by @mbrookhart are reused.
please review @mbrookhart @zhiics @kevinthesun
cc @interesaaat