[TVMC] use target_host when it is set#6855
Merged
comaniac merged 7 commits intoapache:mainfrom Dec 1, 2020
euntaik:tvmc_compiler_fix
Merged
[TVMC] use target_host when it is set#6855comaniac merged 7 commits intoapache:mainfrom euntaik:tvmc_compiler_fix
comaniac merged 7 commits intoapache:mainfrom
euntaik:tvmc_compiler_fix
Conversation
giuseros
reviewed
Nov 5, 2020
Contributor
giuseros
left a comment
giuseros
left a comment
There was a problem hiding this comment.
I like this change.Could you add a test to verify this behavior?
comaniac
added
status: need update
Contributor
|
@euntaik please address the review comments. |
comaniac
approved these changes
Nov 20, 2020
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
Just a nit.
The test case looks not relevant at the first glance, but I guess maybe OpenCL is the more obvious backend that requires target host to be set explicitly?
Comment on lines
+166
to
+170
| # check for output types | ||
| assert type(graph) is str | ||
| assert type(lib) is tvm.runtime.module.Module | ||
| assert type(params) is dict | ||
| assert type(dumps) is dict |
Contributor
There was a problem hiding this comment.
Those checks look not cover anything special? To me, as long as you can compile the model without errors, then you should have used the right target host.
Contributor
comaniac
added
status: accepted
and removed
status: need test case
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* [TVMC] add cl support in tvmc runner * [TVMC] use target_host when it is set * Cleanup comment and asssert device type in else case * add a test for tvmc compiler * remove unused func
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* [TVMC] add cl support in tvmc runner * [TVMC] use target_host when it is set * Cleanup comment and asssert device type in else case * add a test for tvmc compiler * remove unused func
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* [TVMC] add cl support in tvmc runner * [TVMC] use target_host when it is set * Cleanup comment and asssert device type in else case * add a test for tvmc compiler * remove unused func
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feed target_host to the relay.build when it is provided.