[TVMC] use common function to obtain target from --target value on 'tvmc compile'#6788
Merged
comaniac merged 1 commit intoapache:mainfrom Oct 29, 2020
leandron:tvmc_todo_compile_target
Merged
[TVMC] use common function to obtain target from --target value on 'tvmc compile'#6788comaniac merged 1 commit intoapache:mainfrom leandron:tvmc_todo_compile_target
comaniac merged 1 commit intoapache:mainfrom
leandron:tvmc_todo_compile_target
Conversation
…vmc compile' - This is solving a TODO item on tvmc
comaniac
approved these changes
Oct 28, 2020
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
LGTM. Can you also file an issue to list all the TODOs we discussed in previous PRs so that we can easily track the status? Thanks.
7 tasks
Contributor
Author
I raised #6792 to cover the pending items on TVMC backlog. |
Contributor
Author
|
If you're ok with the issue I filed to tackle backlog items, can we merge this one? |
Contributor
|
Thanks @leandron |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
…vmc compile' (apache#6788) - This is solving a TODO item on tvmc
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
…vmc compile' (apache#6788) - This is solving a TODO item on tvmc
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
…vmc compile' (apache#6788) - This is solving a TODO item on tvmc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves a
TODOitem on TVMC, using a common function to obtain the target from--targetin the command line. The common function is already used intvmc tune.cc @comaniac @FrozenGene