[Rust][IRModule] Flesh out IRModule methods by jroesch · Pull Request #6741 · apache/tvm

jroesch · 2020-10-23T06:22:15Z

This PR fully expand the IRModule interface in Rust and fixes a whole host of sharp edges and improves the procedural macros for generating the boilerplate.

cc @mwillsey @altanh @imalsogreg @gussmith23

junrushao

The LLVM flags look good to me

imalsogreg · 2020-10-26T14:16:58Z

 use syn::parse::{Parse, ParseStream, Result};

-use syn::{FnArg, Generics, Ident, Lit, Meta, NestedMeta, Pat, ReturnType, TraitItemMethod, Type};
+use syn::{FnArg, Signature, Attribute, token::Semi, Visibility, Generics, Ident, Lit, Meta, NestedMeta, Pat, ReturnType, Type};


nit: line length

WTB rustfmt

I probably just haven't run it yet, since everything is automatic I tend to just run it when I know I'm gtg.

imalsogreg · 2020-10-26T14:30:04Z

-use syn::{FnArg, Generics, Ident, Lit, Meta, NestedMeta, Pat, ReturnType, TraitItemMethod, Type};
+use syn::{FnArg, Signature, Attribute, token::Semi, Visibility, Generics, Ident, Lit, Meta, NestedMeta, Pat, ReturnType, Type};
+
+struct ExternalItem {


nit: brief rustdoc? Some comments would help me get the story of what ExternalItem and External are for.

What Greg said

imalsogreg · 2020-10-26T14:34:48Z

+        let derives = quote! {
+            impl std::hash::Hash for #ref_id {
+                fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
+                    self.0.hash(state)


Possibly dumb comment (I'm not familiar with this macro) - is self.0 always the right thing to hash? Or is #ref_id sometimes a tuple with multiple fields, where field .1 and .2 etc. may be part of what distinguishes objects when hashing?

No we generate a wrapper new type over the ObjectPtr which contains 1 field always. ObjectPtr is currently dispatching to TVM's C++ hashing so we have cross language consistency.

imalsogreg · 2020-10-26T14:39:31Z

        DataType::new(DL_FLOAT_CODE, bits, lanes)
    }

+    pub const fn float32() -> DataType {


if this is float32, should the old float be renamed to float64 (to avoid clashing with float vs. double size intuition?)

We don't use float/double terminology in TVM due to the fact that both integers and floating point values are both parametric by vector length and bit width. The float method here takes both bit width and vector length, unless I'm missing something.

imalsogreg

I left a couple nit comments and questions. But it seems fine to merge, to me.
Haven't tested anything (I'm not up to speed yet on running TVM or using these rust bindings)

jroesch · 2020-10-31T22:25:40Z

I left a couple nit comments and questions. But it seems fine to merge, to me.
Haven't tested anything (I'm not up to speed yet on running TVM or using these rust bindings)

Its pretty easy to get started, @adelbertc has not repro'd running them if you are interested. I will finish adding tests and ping you guys again.

adelbertc · 2020-11-05T04:35:21Z

-use syn::{FnArg, Generics, Ident, Lit, Meta, NestedMeta, Pat, ReturnType, TraitItemMethod, Type};
+use syn::{FnArg, Signature, Attribute, token::Semi, Visibility, Generics, Ident, Lit, Meta, NestedMeta, Pat, ReturnType, Type};
+
+struct ExternalItem {


What Greg said

jroesch · 2020-11-05T07:26:36Z

@adelbertc @imalsogreg I will try and ship docs for proc macro after landing this branch if that's cool with you guys, just so I can unblock some other branches I have.

electriclilies

I don't know rust very well, but looks good to me

* WIP * WIP * WIP * WIP * Disable WASM and fix rebase * Work on finishing tests * Make entire object system printable * Write some more tests for IRModule * All tests pass * Format * Restore module.cc * Bump syn

junrushao reviewed Oct 23, 2020

View reviewed changes

imalsogreg reviewed Oct 26, 2020

View reviewed changes

Comment thread rust/tvm-rt/src/value.rs

imalsogreg reviewed Oct 26, 2020

View reviewed changes

Comment thread rust/tvm/src/ir/module.rs

imalsogreg approved these changes Oct 26, 2020

View reviewed changes

jroesch force-pushed the rust-improve-ir-mod branch from 9608878 to d871c53 Compare November 2, 2020 02:31

jroesch added 9 commits November 4, 2020 17:57

WIP

57c72f5

WIP

7a5869e

WIP

b2d0095

WIP

b784534

Disable WASM and fix rebase

a39a1bf

Work on finishing tests

3e8cd8e

Make entire object system printable

1b72ca0

Write some more tests for IRModule

fdaa4af

All tests pass

726a01b

jroesch force-pushed the rust-improve-ir-mod branch from d871c53 to 726a01b Compare November 5, 2020 03:05

jroesch added 2 commits November 4, 2020 19:05

Format

79275b3

Restore module.cc

6875ac7

adelbertc approved these changes Nov 5, 2020

View reviewed changes

Bump syn

da2ab07

tqchen approved these changes Nov 5, 2020

View reviewed changes

electriclilies approved these changes Nov 5, 2020

View reviewed changes

jroesch merged commit a4bd5f8 into apache:main Nov 5, 2020

jroesch deleted the rust-improve-ir-mod branch February 4, 2021 04:44

junrushao mentioned this pull request Nov 1, 2021

Apache TVM v0.8 Release Note Candidate #9416

Closed

Conversation

jroesch commented Oct 23, 2020

Uh oh!

junrushao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

imalsogreg left a comment

Choose a reason for hiding this comment

Uh oh!

jroesch commented Oct 31, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jroesch commented Nov 5, 2020

Uh oh!

electriclilies left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants