[Hexagon] Use nullptr instead of 0 in hexagon_device_sim.cc#6718
Merged
tqchen merged 1 commit intoapache:mainfrom Oct 24, 2020
kparzysz-quic:nullptr
Merged
[Hexagon] Use nullptr instead of 0 in hexagon_device_sim.cc#6718tqchen merged 1 commit intoapache:mainfrom kparzysz-quic:nullptr
tqchen merged 1 commit intoapache:mainfrom
kparzysz-quic:nullptr
Conversation
jverma-quic
approved these changes
Oct 20, 2020
Member
|
The CI fail is not relevant to this PR, which I believe has been fixed recently. Would you like to rebase and retrigger the CI? Thanks! |
Passing 0 produces compilation warnings.
tqchen
approved these changes
Oct 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing 0 produces compilation warnings.