Skip to content

[Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.#6656

Merged
junrushao merged 32 commits intoapache:mainfrom
jroesch:rust-diag
Nov 2, 2020
Merged

[Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.#6656
junrushao merged 32 commits intoapache:mainfrom
jroesch:rust-diag

Conversation

@jroesch
Copy link
Copy Markdown
Member

@jroesch jroesch commented Oct 9, 2020

This PR exposes new diagnostics to Rust so we can reuse the better libraries for diagnostics rendering via Rust.

@jroesch jroesch changed the title [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface. [Rust][Diagnostics][WIP] Add initial boilerplate for Rust diagnostic interface. Oct 9, 2020
@jroesch
Copy link
Copy Markdown
Member Author

jroesch commented Oct 9, 2020

cc @gussmith23 and @mwillsey

@tqchen tqchen changed the base branch from master to main October 11, 2020 18:16
@jroesch jroesch changed the title [Rust][Diagnostics][WIP] Add initial boilerplate for Rust diagnostic interface. [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface. Oct 16, 2020
jroesch
jroesch commented Oct 16, 2020
View reviewed changes
Comment thread rust/compiler-ext/Cargo.toml Outdated
tkonolige
tkonolige reviewed Oct 16, 2020
View reviewed changes
Comment thread rust/compiler-ext/src/lib.rs Outdated
tkonolige
tkonolige reviewed Oct 16, 2020
View reviewed changes
Comment thread rust/tvm/src/ir/diagnostics/codespan.rs
rkimball
rkimball suggested changes Oct 16, 2020
View reviewed changes
Comment thread cmake/modules/RustExt.cmake Outdated
rkimball
rkimball suggested changes Oct 22, 2020
View reviewed changes
Comment thread rust/tvm/src/ir/diagnostics/mod.rs Outdated
Comment thread rust/tvm/src/ir/span.rs Outdated
Comment thread cmake/modules/RustExt.cmake Outdated
Comment thread CMakeLists.txt Outdated
@jroesch
Copy link
Copy Markdown
Member Author

jroesch commented Oct 26, 2020

I think this one is now ready to roll.

tkonolige
tkonolige reviewed Oct 26, 2020
View reviewed changes
Comment thread cmake/modules/LLVM.cmake
tkonolige
tkonolige reviewed Oct 26, 2020
View reviewed changes
Comment thread cmake/modules/RustExt.cmake Outdated
jroesch and others added 3 commits October 30, 2020 13:51
@jroesch @tkonolige
Update cmake/modules/LLVM.cmake
e8fd9a5 
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
@jroesch
Format Rust
e92adcc
@jroesch
Add TK's suggestion
5731a60
adelbertc
adelbertc reviewed Oct 31, 2020
View reviewed changes
Comment thread rust/compiler-ext/Cargo.toml Outdated
Comment thread rust/compiler-ext/Cargo.toml
Comment thread rust/tvm-rt/src/array.rs Outdated

fn next(&mut self) -> Option<Self::Item> {
if self.pos < self.size {
let item = self.array.get(self.pos).expect("should not fail");
Copy link
Copy Markdown
Contributor

@adelbertc adelbertc Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though exceptional, better error message here than "should not fail"

Comment thread rust/tvm-rt/src/function.rs
Comment thread rust/tvm-rt/src/function.rs Outdated
Comment thread rust/tvm/src/bin/tyck.rs Outdated
Comment thread rust/tvm/src/bin/tyck.rs Outdated
Comment thread rust/tvm/src/bin/tyck.rs
Comment thread rust/tvm/src/ir/diagnostics/codespan.rs
}

/// A mapping for all files in a source map to byte ranges.
struct SpanToByteRange {
Copy link
Copy Markdown
Contributor

@adelbertc adelbertc Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a place where we could integrating like tracing-style spans? (looking for PR ideas)

Comment thread rust/tvm/src/ir/module.rs

#[derive(Error, Debug)]
pub enum Error {
#[error("{0}")]
Copy link
Copy Markdown
Contributor

@adelbertc adelbertc Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to use #[source] for the errors?

Copy link
Copy Markdown
Member Author

@jroesch jroesch Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of stuff would be good follow up work imo.

@junrushao junrushao merged commit 883954e into apache:main Nov 2, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
@jroesch @rkimball @tkonolige
[Rust][Diagnostics] Add initial boilerplate for Rust diagnostic inter…
c5500ac 
…face. (apache#6656)

* Add initial boilerplate for Rust diagnostic interface.

* Codespan example almost working

* WIP

* Hacking on Rust inside of TVM

* Borrow code from Egg

* Update CMake and delete old API

* Fix Linux build

* Clean up exporting to show off new diagnostics

* Improve Rust bindings

* Fix calling

* Fix

* Rust Diagnostics work

* Remove type checker

* Format and cleanup

* Fix the extension code

* More cleanup

* Fix some CR

* Add docs and address feedback

* WIP more improvments

* Update cmake/modules/RustExt.cmake

Co-authored-by: Robert Kimball <bobkimball@gmail.com>

* Update rust/tvm/src/ir/diagnostics/mod.rs

Co-authored-by: Robert Kimball <bobkimball@gmail.com>

* Clean up PR

* Format all

* Remove dead comment

* Code review comments  and apache  headers

* Purge test file

* Update cmake/modules/LLVM.cmake

Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>

* Format Rust

* Add TK's suggestion

* More CR and cleanup

* Fix tyck line

* Format

Co-authored-by: Robert Kimball <bobkimball@gmail.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
@jroesch @rkimball @tkonolige
[Rust][Diagnostics] Add initial boilerplate for Rust diagnostic inter…
72ab03f 
…face. (apache#6656)

* Add initial boilerplate for Rust diagnostic interface.

* Codespan example almost working

* WIP

* Hacking on Rust inside of TVM

* Borrow code from Egg

* Update CMake and delete old API

* Fix Linux build

* Clean up exporting to show off new diagnostics

* Improve Rust bindings

* Fix calling

* Fix

* Rust Diagnostics work

* Remove type checker

* Format and cleanup

* Fix the extension code

* More cleanup

* Fix some CR

* Add docs and address feedback

* WIP more improvments

* Update cmake/modules/RustExt.cmake

Co-authored-by: Robert Kimball <bobkimball@gmail.com>

* Update rust/tvm/src/ir/diagnostics/mod.rs

Co-authored-by: Robert Kimball <bobkimball@gmail.com>

* Clean up PR

* Format all

* Remove dead comment

* Code review comments  and apache  headers

* Purge test file

* Update cmake/modules/LLVM.cmake

Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>

* Format Rust

* Add TK's suggestion

* More CR and cleanup

* Fix tyck line

* Format

Co-authored-by: Robert Kimball <bobkimball@gmail.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
@jroesch @rkimball
@tkonolige @trevor-m
[Rust][Diagnostics] Add initial boilerplate for Rust diagnostic inter…
5d09cfd 
…face. (apache#6656)

* Add initial boilerplate for Rust diagnostic interface.

* Codespan example almost working

* WIP

* Hacking on Rust inside of TVM

* Borrow code from Egg

* Update CMake and delete old API

* Fix Linux build

* Clean up exporting to show off new diagnostics

* Improve Rust bindings

* Fix calling

* Fix

* Rust Diagnostics work

* Remove type checker

* Format and cleanup

* Fix the extension code

* More cleanup

* Fix some CR

* Add docs and address feedback

* WIP more improvments

* Update cmake/modules/RustExt.cmake

Co-authored-by: Robert Kimball <bobkimball@gmail.com>

* Update rust/tvm/src/ir/diagnostics/mod.rs

Co-authored-by: Robert Kimball <bobkimball@gmail.com>

* Clean up PR

* Format all

* Remove dead comment

* Code review comments  and apache  headers

* Purge test file

* Update cmake/modules/LLVM.cmake

Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>

* Format Rust

* Add TK's suggestion

* More CR and cleanup

* Fix tyck line

* Format

Co-authored-by: Robert Kimball <bobkimball@gmail.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
@jroesch jroesch deleted the rust-diag branch February 4, 2021 04:42
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tkonolige tkonolige tkonolige left review comments

@junrushao junrushao junrushao approved these changes

+2 more reviewers

@adelbertc adelbertc adelbertc approved these changes

@rkimball rkimball rkimball approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jroesch @adelbertc @tkonolige @rkimball @junrushao