[Frontend][Tensorflow] Fix TF 1.15 conv2d_transpose parsing#6589
Merged
tqchen merged 2 commits intoapache:masterfrom Oct 11, 2020
Merged
[Frontend][Tensorflow] Fix TF 1.15 conv2d_transpose parsing#6589tqchen merged 2 commits intoapache:masterfrom
tqchen merged 2 commits intoapache:masterfrom
Conversation
siju-samuel
reviewed
Sep 29, 2020
Member
siju-samuel
left a comment
There was a problem hiding this comment.
@jtuyls Good catch. Thanks for the contribution.
Can you add a testcase convering this scenario as well?
Contributor
Author
|
@siju-samuel I guess this issue is really caused by not using AddShapesToGraphDef but I think it's still useful to include the small changes to cover this case. So I added checks for that to the Tensorflow convolution tests. Could you have a look? Additionally, we could maybe add tests for this case to the other operations? |
Member
|
Thanks @jtuyls @siju-samuel |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 13, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 14, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Tensorflow 1.15.0 conv2d_transpose parsing. Specifically, attr["_output_shapes"][0] can be None.
Following snippet can be used to create a model for reproducing the bug (run with TF 1.15.0):
In general, I think it might be useful to adjust the CI to run the frontend tests with multiple versions of the the external frameworks to verify compatibility with the versions we want to support?
@siju-samuel @masahi, could you have a look?