Merged
Conversation
tqchen
requested changes
Sep 1, 2020
yzhliu
requested changes
Sep 4, 2020
Member
yzhliu
left a comment
yzhliu
left a comment
There was a problem hiding this comment.
Please fix the lint problem, remember you can use tests/lint/git-clang-format.sh to lint cpp code automatically.
hanke580
force-pushed
the
einsum
branch
2 times, most recently
from
c735e9e to
64b31c7
Compare
yzhliu
reviewed
Sep 16, 2020
Member
hanke580
force-pushed
the
einsum
branch
2 times, most recently
from
e779c08 to
f9f7e76
Compare
Member
Member
|
will do shortly. |
yzhliu
reviewed
Jan 8, 2021
Member
|
pls also rebase and retrigger the ci. |
hanke580
force-pushed
the
einsum
branch
2 times, most recently
from
7e93d3d to
71916d6
Compare
yzhliu
approved these changes
Jan 19, 2021
Member
yzhliu
left a comment
yzhliu
left a comment
There was a problem hiding this comment.
@tqchen @hzfan @junrushao1994 could you help to do another round of review?
Member
|
also cc @ZihengJiang |
Contributor
|
@hanke580 Nice work! I did not realize that we already has an implementation for |
ZihengJiang
requested changes
Jan 22, 2021
Member
|
Gentle ping @tqchen @ZihengJiang seems @hanke580 has resolved your comment. We could go on following steps. |
ZihengJiang
approved these changes
Feb 3, 2021
Contributor
|
LGTM! |
junrushao
approved these changes
Feb 3, 2021
tqchen
approved these changes
Feb 3, 2021
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* [TOPI] Einsum * Fix tuple * fix oshape * * test * * Fix lint * * Remove useless define * * Move to einsum header file * * Fix single value situation * * Fix CamelASE * * Print stride * * Fix single input bug * * fix lint * * Fix lint and add comments * * create test einsum * * Fix lint * * Fix comments
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* [TOPI] Einsum * Fix tuple * fix oshape * * test * * Fix lint * * Remove useless define * * Move to einsum header file * * Fix single value situation * * Fix CamelASE * * Print stride * * Fix single input bug * * fix lint * * Fix lint and add comments * * create test einsum * * Fix lint * * Fix comments
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* [TOPI] Einsum * Fix tuple * fix oshape * * test * * Fix lint * * Remove useless define * * Move to einsum header file * * Fix single value situation * * Fix CamelASE * * Print stride * * Fix single input bug * * fix lint * * Fix lint and add comments * * create test einsum * * Fix lint * * Fix comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.