[TE] Add LegalizeInvalidAttach to legalize the compute_at location after split or fuse#5917
Merged
merrymercy merged 5 commits intoapache:masterfrom Jun 26, 2020
Merged
Conversation
Member
Author
comaniac
requested changes
Jun 24, 2020
Contributor
comaniac
left a comment
There was a problem hiding this comment.
Overall LGTM in terms of the functionality.
Member
Author
7 tasks
comaniac
approved these changes
Jun 25, 2020
Member
|
cc @vinx13 @Hzfengsy @spectrometerHBH please also help to take a look, we can proceed to merge after reviews by a few more eyes |
junrushao
approved these changes
Jun 26, 2020
| .python_history | ||
| .pytest_cache | ||
| .local | ||
| cmake-build-debug |
Member
There was a problem hiding this comment.
Maybe we don’t need this line
Member
Author
There was a problem hiding this comment.
It is produced by my Jetbrain Clion
Hzfengsy
approved these changes
Jun 26, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
…ter split or fuse (apache#5917) * Add LegalizeInvalidAttach * lint & typo * lint & typo * address comment * fix lint
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
…ter split or fuse (apache#5917) * Add LegalizeInvalidAttach * lint & typo * lint & typo * address comment * fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
LegalizeInvalidAttachinSchedule::normalizeto legalize the compute_at location if the target iterator of compute_at is split or fused.Case 2 can only happen if the target of compute_at is the innermost operand of fuse operation.
Examples: the following two cases will crash the compiler before this fix, but they are legal after this fix.