Skip to content

Qnn fully connected#3910

Merged
zhiics merged 7 commits intoapache:masterfrom
anijain2305:qnn_fully_connected
Sep 22, 2019
Merged

Qnn fully connected#3910
zhiics merged 7 commits intoapache:masterfrom
anijain2305:qnn_fully_connected

Conversation

@shoubhik
Copy link
Copy Markdown
Contributor

@shoubhik shoubhik commented Sep 6, 2019

This is continuation of the Qnn dialect. After the convolution #3580 this the implementaion of Dense layer with quantized inputs. In future revisions we will add schdules for more optimal performance.

@shoubhik
Copy link
Copy Markdown
Contributor Author

shoubhik commented Sep 6, 2019

@anijain2305 @zhiics @vinx13 can you take a look at this PR.

Copy link
Copy Markdown
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Some minor comments.

Comment thread src/relay/pass/pattern_util.h Outdated
Comment thread python/tvm/relay/qnn/op/qnn.py
Comment thread src/relay/qnn/op/dense.cc
Comment thread src/relay/qnn/op/dense.cc Outdated
Comment thread src/relay/qnn/op/dense.cc Outdated
Comment thread src/relay/qnn/op/dense.cc Outdated
Comment thread src/relay/qnn/op/dense.cc Outdated
Comment thread src/relay/qnn/op/dense.cc
Comment thread tests/python/relay/test_qnn_dense.py Outdated
Comment thread src/relay/qnn/op/convolution.cc
@shoubhik
Copy link
Copy Markdown
Contributor Author

shoubhik commented Sep 9, 2019

@zhiics @vinx13 @jackwish can you take a look at this PR.

@anijain2305
Copy link
Copy Markdown
Contributor

@shoubhik Can you please fix the lint?

@zhiics @vinx13 Can you please review?

@shoubhik
Copy link
Copy Markdown
Contributor Author

Fixed the test related issue.

Copy link
Copy Markdown
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a few nits.
@jackwish Could you take a look as well when you have cycles?

Also, plz fix the ci error.

Comment thread python/tvm/relay/qnn/op/qnn.py
Comment thread python/tvm/relay/qnn/op/qnn.py
@shoubhik
Copy link
Copy Markdown
Contributor Author

@jackwish Could you take a look

Copy link
Copy Markdown
Contributor

@zhenhuaw-me zhenhuaw-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry that I have missed this :)

@shoubhik
Copy link
Copy Markdown
Contributor Author

@zhiics can you merge this.

@zhiics zhiics merged commit 43f54a5 into apache:master Sep 22, 2019
@zhiics
Copy link
Copy Markdown
Member

zhiics commented Sep 22, 2019

Thanks everyone. This is now merged.

wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
* Qnn Dense layer.

* Reformatting code.

* Reformatting code and making the test case more readable.

* Fixing lint issues.

* Fixing test method names to pass the nose related configurations.

* Aligning the code for code style.
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
* Qnn Dense layer.

* Reformatting code.

* Reformatting code and making the test case more readable.

* Fixing lint issues.

* Fixing test method names to pass the nose related configurations.

* Aligning the code for code style.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 1, 2019
* Qnn Dense layer.

* Reformatting code.

* Reformatting code and making the test case more readable.

* Fixing lint issues.

* Fixing test method names to pass the nose related configurations.

* Aligning the code for code style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants