[relay][heterogeneous] annotate using visitor#3261
Merged
jroesch merged 2 commits intoapache:masterfrom Jun 1, 2019
Merged
Conversation
jroesch
reviewed
May 31, 2019
|
|
||
| Expr VisitExpr_(const CallNode* call_node) final { | ||
| if (IsOnDeviceNode(call_node) || IsDeviceCopyNode(call_node)) { | ||
| if (IsOnDeviceNode(call_node)) { |
Member
There was a problem hiding this comment.
This is the only meaningful change right? this will just search deeper in the tree to rewrite until we hit another device annotation? just want to make sure I 100% understand this time.
Member
Author
There was a problem hiding this comment.
yes, for example, on_device connects a and b expression, a -> on_device -> b, we have inserted device_copy when we visit b. Anytime when we visit on_device, if means we either have inserted device_copy op, or it is not necessary, therefore, we can safely delete on_device by returning 'a.
jroesch
approved these changes
Jun 1, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
* annotate using visitor * retrigger CI
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
* annotate using visitor * retrigger CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, there are some discussions about how to leverage an additional pass to annotate a Relay program for heterogeneous compilation. This PR adds a unit test to show it and it slightly changes the manual way for annotation. Now users need to connect nodes but don't need to pass the annotation exprs to the backend.
This following example has been executed locally:
cc' @jroesch this should be what you want.
@imorinaga @anijain2305 @jwfromm