[Relay][Frontend] Caffe2 Support by makihiro · Pull Request #2507 · apache/tvm

makihiro · 2019-01-25T06:11:19Z

@hlu1 @tqchen @zhreshold @kazum Please help to review.

yzhliu · 2019-01-27T07:39:42Z

Please satisfy the CI

from model_zoo import c2_squeezenet, c2_resnet50, c2_vgg19

  File "/workspace/tests/python/frontend/caffe2/model_zoo/__init__.py", line 19, in <module>

    locals()['c2_' + model] = importlib.import_module('caffe2.python.models.' + model)

  File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module

    return _bootstrap._gcd_import(name[level:], package, level)

ModuleNotFoundError: No module named 'caffe2.python.models.squeezenet'

yzhliu · 2019-01-27T07:43:37Z

+    with relay.build_config(opt_level=3):
+        graph, lib, params = relay.build(func, target, params=params)
+
+    ctx = tvm.cpu(0)


can we use tvm.relay.testing.config.ctx_list to test it on all supported targets?

ctx comes from ctx_list and I'm going to remove ctx = tvm.cpu(0)

kazum · 2019-01-28T05:01:14Z

+if __name__ == '__main__':
+    verify_squeezenet1_1()
+    verify_resnet50()
+    verify_vgg19()


Test methods should start with "test_" so that nosetests can execute them.

Thank you for the review. I fixed them.

yzhliu · 2019-01-28T21:49:55Z

@makihiro could you act on the comments?

makihiro · 2019-01-29T02:44:55Z

@makihiro could you act on the comments?

Thank you for the comments, and sorry for the late reply.
Module import error occurred due to no caffe2 models installed on CI environment.
The test code tries to download models and install into caffe2 path, however there is permission error for this operation.
The best solution is caffe2 models are pre-installed on CI environment because total model size is several hundreds of megabytes.
To fix this, I'm going to modify to download models into temporary directory (eg. /tmp) and load / or modify dockerfile to install models for CI container.

…ode reviews)

kazum · 2019-01-29T19:58:59Z

+        locals()['c2_' + model] = importlib.import_module('caffe2.python.models.' + model)
+    except ImportError:
+        try:
+            os.system("python3 -m caffe2.python.models.download -i -f " + model)


This doesn't work with python2.

I think no need to write download code. You can use the caffe2 downloader module instead, which downloads models to "~/.caffe2" by default.

from caffe2.python.models.download import ModelDownloader mf = ModelDownloader() mf.get_c2_model(model)

Thank you for the review. I fixed code to use ModelDownloader

kazum · 2019-01-29T20:04:37Z

+if __name__ == '__main__':
+    test_verify_squeezenet1_1()
+    test_verify_resnet50()
+    test_verify_vgg19()


Replace 'test_verify' with 'test_forward' to be consistent with other frontend tests.

I renamed functions in a manner similar to other frontend tests.

…rward)

kazum

Looks good to me.

tqchen · 2019-01-31T18:05:25Z

@hlu1 can you also take a quick look?

makihiro · 2019-02-01T06:23:39Z

I would like to add the tutorial. Please help to review.

yzhliu

good to me

* [Relay][Frontend] Add Caffe2 Support * [Relay][Frontend] Add Caffe2 Support (fix unsed import) * [Relay][Frontend] Add Caffe2 Support (fix caffe2 model import) * [Relay][Frontend] Add Caffe2 Support (fix model install and reflect code reviews) * [Relay][Frontend] Add Caffe2 Support (fix caffe2 model import) * [Relay][Frontend] Add Caffe2 Support (fix caffe2 model import) * [Relay][Frontend] Add Caffe2 Support (fix caffe2 model import) * [Relay][Frontend] Add Caffe2 Support (fix caffe2 frontend import) * [Relay][Frontend] Add Caffe2 Support (rename function name in test_forward) * [Relay][Frontend] Add Caffe2 Support (fix caffe2 model import) * [Relay][Frontend] Add Caffe2 Support (fix caffe2 model import) * [Doc] Caffe2 frontend tutorial * [Doc] Caffe2 frontend tutorial * [Doc] Caffe2 frontend tutorial * [Relay][Frontend] Add Caffe2 Support (remove unsed file)

[Relay][Frontend] Add Caffe2 Support

4b4172a

makihiro mentioned this pull request Jan 25, 2019

[RELAY][FRONEND] Frontend scalfolding #2246

Closed

8 tasks

makihiro added 2 commits January 25, 2019 15:34

[Relay][Frontend] Add Caffe2 Support (fix unsed import)

c081677

[Relay][Frontend] Add Caffe2 Support (fix caffe2 model import)

07fcbf5

tqchen added the status: need review label Jan 25, 2019

yzhliu reviewed Jan 27, 2019

View reviewed changes

kazum requested changes Jan 28, 2019

View reviewed changes

yzhliu mentioned this pull request Jan 28, 2019

TVM 0.5 Release Note #2448

Closed

makihiro added 5 commits January 29, 2019 15:29

[Relay][Frontend] Add Caffe2 Support (fix model install and reflect c…

0d8b354

…ode reviews)

[Relay][Frontend] Add Caffe2 Support (fix caffe2 model import)

7ec284a

[Relay][Frontend] Add Caffe2 Support (fix caffe2 model import)

32202cc

[Relay][Frontend] Add Caffe2 Support (fix caffe2 model import)

1ba933e

[Relay][Frontend] Add Caffe2 Support (fix caffe2 frontend import)

0ab0a69

kazum requested changes Jan 29, 2019

View reviewed changes

makihiro added 4 commits January 30, 2019 10:01

[Relay][Frontend] Add Caffe2 Support (rename function name in test_fo…

765bd9d

…rward)

fetch upstream master and resolve conflict

da302f1

[Relay][Frontend] Add Caffe2 Support (fix caffe2 model import)

4cb77b4

[Relay][Frontend] Add Caffe2 Support (fix caffe2 model import)

324eb62

kazum approved these changes Jan 30, 2019

View reviewed changes

[Doc] Caffe2 frontend tutorial

b2c90a3

makihiro added 4 commits February 1, 2019 12:15

[Doc] Caffe2 frontend tutorial

871c39e

[Doc] Caffe2 frontend tutorial

30bdc9d

[Relay][Frontend] Add Caffe2 Support (remove unsed file)

ea664fa

Merge branch 'relay-caffe2-tutorial' into relay-caffe2

22635cb

yzhliu approved these changes Feb 2, 2019

View reviewed changes

yzhliu merged commit b3b3d28 into apache:master Feb 2, 2019

yzhliu mentioned this pull request Mar 2, 2019

[DEV] TVM v0.6 Roadmap #2623

Closed

28 tasks

Conversation

makihiro commented Jan 25, 2019

Uh oh!

yzhliu commented Jan 27, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yzhliu commented Jan 28, 2019

Uh oh!

makihiro commented Jan 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kazum left a comment

Choose a reason for hiding this comment

Uh oh!

tqchen commented Jan 31, 2019

Uh oh!

makihiro commented Feb 1, 2019

Uh oh!

yzhliu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

makihiro commented Jan 29, 2019 •

edited

Loading