[Hybrid script] Backend support by were · Pull Request #2477 · apache/tvm

were · 2019-01-21T21:04:55Z

Finally, the interface looks like:

module = tvm.hybrid.build(sch, ins, outs)

In general, two major things are going in this PR:
A hybrid script text format is supported:

It has better naming support than the default IRPrinter.
When designing hybrid script it is for Phase 0 IR, so this dumper cannot be a standalone dumper. You can only use it to dump Phase 0 IR.
Stores hybrid script as source code.
Can be used the same as a hybrid script function (both sw emu & hw run).

Minor things:

Hybrid code module refactor:
1.1 util.py & calls.py mainly is in charge of compilation time, and intrinsic.py is renamed to runtime.py to be in charge of hybrid script runtime.
1.2 Redundant api.py is merged to __init.py.
AssertStmt is supported; type cast is supported as it is required by [TOPI][CUDA] Add faster-rcnn proposal op #2420.

were · 2019-02-12T05:05:19Z

@tqchen @xqdan @junrushao1994 @merrymercy @kevinthesun
I think this PR is mature enough.

were · 2019-02-12T06:46:57Z

@Laurawly @vinx13 Anyone can take a look?

xqdan

looks good to me now, thanks @were

junrushao

looks good

tqchen · 2019-02-13T17:53:26Z

A good set of changes. Note that we do not need to make hybrid dump optional. The reason that random and NNPack are optional is that they are linked into the runtime library and have additional dependencies.

Hybrid dump is a compiler feature, that you should add to COMPILER_SRCS by default

tqchen · 2019-02-13T17:57:23Z

@Laurawly please moderate this pr as per https://docs.tvm.ai/contribute/committer_guide.html

tqchen

change build rule as per my comment

were · 2019-02-13T18:53:12Z

@tqchen Done.

were · 2019-02-13T18:53:27Z

change build rule as per my comment

Done.

Laurawly · 2019-02-13T23:46:54Z

Thanks @were @junrushao1994 @xqdan @vinx13 , this is now merged

@vinx13

* a preliminary version is done? * we no longer need the redundant hybrid/api.py * support assert stmt * cast supported * intrin -> runtime; util is mainly in charge of compilation time * assert statement * fix python lint * fix cpp lint * on the way to module * rollback .cc * fix typo, no direct expose then * @vinx13 ceil is added i guess? * wip... * temp commit * fix import * i preliminary version is done? * on the way to build hybrid module * nearly fixed... * dumped python are equiv as original python * on the way to bootstrap * cpu bootstrap done * bootstrap! * fix lint * fix doc * resolve some review concerns * support load/save * fix lint * thanks to xqdan fixed my typo * fix build, make dump non-optional * add vthread * jesus why i added this

@vinx13

* a preliminary version is done? * we no longer need the redundant hybrid/api.py * support assert stmt * cast supported * intrin -> runtime; util is mainly in charge of compilation time * assert statement * fix python lint * fix cpp lint * on the way to module * rollback .cc * fix typo, no direct expose then * @vinx13 ceil is added i guess? * wip... * temp commit * fix import * i preliminary version is done? * on the way to build hybrid module * nearly fixed... * dumped python are equiv as original python * on the way to bootstrap * cpu bootstrap done * bootstrap! * fix lint * fix doc * resolve some review concerns * support load/save * fix lint * thanks to xqdan fixed my typo * fix build, make dump non-optional * add vthread * jesus why i added this

@vinx13

* a preliminary version is done? * we no longer need the redundant hybrid/api.py * support assert stmt * cast supported * intrin -> runtime; util is mainly in charge of compilation time * assert statement * fix python lint * fix cpp lint * on the way to module * rollback .cc * fix typo, no direct expose then * @vinx13 ceil is added i guess? * wip... * temp commit * fix import * i preliminary version is done? * on the way to build hybrid module * nearly fixed... * dumped python are equiv as original python * on the way to bootstrap * cpu bootstrap done * bootstrap! * fix lint * fix doc * resolve some review concerns * support load/save * fix lint * thanks to xqdan fixed my typo * fix build, make dump non-optional * add vthread * jesus why i added this

xqdan reviewed Jan 22, 2019

View reviewed changes

Comment thread python/tvm/build_module.py Outdated

Comment thread python/tvm/hybrid/__init__.py Outdated

Comment thread python/tvm/hybrid/__init__.py

vinx13 reviewed Jan 23, 2019

View reviewed changes

Comment thread python/tvm/hybrid/runtime.py Outdated

were force-pushed the hybrid-module branch from a7c432e to baaaa6a Compare February 11, 2019 20:59

Jian Weng added 22 commits February 11, 2019 13:04

a preliminary version is done?

4b81b22

we no longer need the redundant hybrid/api.py

b285068

support assert stmt

de3ad83

cast supported

790396c

intrin -> runtime; util is mainly in charge of compilation time

4be2d5f

assert statement

b0981b0

fix python lint

6c0d984

fix cpp lint

557472b

on the way to module

c1f4464

rollback .cc

f1d636a

fix typo, no direct expose then

942d4b6

@vinx13 ceil is added i guess?

4f2e842

wip...

151f0fe

temp commit

baaaa6a

fix import

b64cd4e

i preliminary version is done?

9847ef9

on the way to build hybrid module

6debdf1

nearly fixed...

5d614d4

dumped python are equiv as original python

39048da

on the way to bootstrap

11d2077

cpu bootstrap done

3866e1c

bootstrap!

5375aba

were changed the title ~~[WIP] [Hybrid script] Backend support~~ [Hybrid script] Backend support Feb 12, 2019

Jian Weng added 2 commits February 11, 2019 21:08

fix lint

363c4a9

fix doc

d129948

fix lint

3d495f3

xqdan reviewed Feb 13, 2019

View reviewed changes

Comment thread tests/python/unittest/test_hybrid_script.py Outdated

thanks to xqdan fixed my typo

3d086cb

xqdan approved these changes Feb 13, 2019

View reviewed changes

Laurawly approved these changes Feb 13, 2019

View reviewed changes

vinx13 approved these changes Feb 13, 2019

View reviewed changes

junrushao approved these changes Feb 13, 2019

View reviewed changes

tqchen requested changes Feb 13, 2019

View reviewed changes

Laurawly reviewed Feb 13, 2019

View reviewed changes

Comment thread src/contrib/hybrid/codegen_hybrid.cc

tqchen requested changes Feb 13, 2019

View reviewed changes

Comment thread .ycm_extra_conf.py Outdated

Laurawly self-assigned this Feb 13, 2019

Jian Weng added 2 commits February 13, 2019 10:56

fix build, make dump non-optional

fcc761d

add vthread

17c4a85

tqchen approved these changes Feb 13, 2019

View reviewed changes

jesus why i added this

f2b00f1

Laurawly added the status: accepted label Feb 13, 2019

Laurawly merged commit c53dd10 into apache:master Feb 13, 2019

were mentioned this pull request Feb 14, 2019

TVM 0.5 Release Note #2448

Closed

tqchen mentioned this pull request Feb 27, 2019

[RFC] [Hybrid Script] A hybrid script backend #2432

Closed

yzhliu mentioned this pull request Mar 2, 2019

[DEV] TVM v0.6 Roadmap #2623

Closed

28 tasks

tqchen mentioned this pull request Nov 8, 2019

[RELEASE][DRAFT] TVM v0.6 Release candidate #4259

Closed

were deleted the hybrid-module branch July 22, 2021 22:57

Conversation

were commented Jan 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

were commented Feb 12, 2019

Uh oh!

were commented Feb 12, 2019

Uh oh!

Uh oh!

xqdan left a comment

Choose a reason for hiding this comment

Uh oh!

junrushao left a comment

Choose a reason for hiding this comment

Uh oh!

tqchen commented Feb 13, 2019

Uh oh!

tqchen commented Feb 13, 2019

Uh oh!

tqchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

were commented Feb 13, 2019

Uh oh!

were commented Feb 13, 2019

Uh oh!

Uh oh!

Laurawly commented Feb 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

were commented Jan 21, 2019 •

edited

Loading

Laurawly commented Feb 13, 2019 •

edited

Loading