Skip to content

[BUGFIX] [Hybrid Script] fix in-correct value index in hybrid script#2268

Merged
tqchen merged 4 commits intoapache:masterfrom
were:fix-value-idx
Dec 13, 2018
Merged

[BUGFIX] [Hybrid Script] fix in-correct value index in hybrid script#2268
tqchen merged 4 commits intoapache:masterfrom
were:fix-value-idx

Conversation

@were
Copy link
Copy Markdown
Contributor

@were were commented Dec 11, 2018

@kevinthesun
My bad, I did not realize that it is possible that upper stream tensors have value_index which is not 0.

@were
Copy link
Copy Markdown
Contributor Author

were commented Dec 11, 2018

@tqchen @yzhliu Anyone can let this quick fix in so that Yao can move forward?

@tqchen
Copy link
Copy Markdown
Member

tqchen commented Dec 11, 2018

Please add a regression testcase

@were
Copy link
Copy Markdown
Contributor Author

were commented Dec 12, 2018

@tqchen Done.

@tqchen tqchen merged commit 4bbf96e into apache:master Dec 13, 2018
@tqchen
Copy link
Copy Markdown
Member

tqchen commented Dec 13, 2018

Thanks, @kevinthesun @were , this is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants