[RELAY]full, full_like compute and schedule#2170
Merged
Merged
Conversation
Member
|
Thanks, please request review. |
siju-samuel
force-pushed
the
relay_full_comp_schd
branch
from
c86474e to
599a422
Compare
Member
Author
|
@MarisaKirisame @jroesch @yzhliu @tqchen please help to review this PR. TIA |
Member
|
Looks good to me, would be good to merge this before #2144 so we can synchronize on the operator implementations. |
MarisaKirisame
approved these changes
Nov 27, 2018
| const Array<Tensor>& inputs, | ||
| const Type& out_type, | ||
| const Target& target) { | ||
| return { topi::full_like(inputs[0], inputs[1]()) }; |
Contributor
There was a problem hiding this comment.
If I am you, i will CHECK inputs size before return.
Maybe we should have a convention for how much CHECKing we should do? idk.
Member
Author
There was a problem hiding this comment.
input size is verified at the FullLikeRel, I guess again checking will b reduntant. most of new compute func doesnt have this checks.
tqchen
approved these changes
Nov 27, 2018
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.