[RELAY]sch and compute for reduce ops#2091
Merged
tqchen merged 2 commits intoapache:masterfrom Nov 26, 2018
Merged
Conversation
Member
|
Looks good to me once CI passes. |
3822b2a to
775fdb0
Compare
Member
Author
Any idea why |
7b96479 to
9775d5d
Compare
9775d5d to
c113712
Compare
fd7f81f to
e178285
Compare
9d8b87c to
204fc60
Compare
204fc60 to
18d772f
Compare
tqchen
requested changes
Nov 22, 2018
| const Target& target) { | ||
| const auto* param = attrs.as<ReduceAttrs>(); | ||
| auto r_axes = GetReduceAxes(inputs[0]->shape.size(), | ||
| param->axis, param->exclude); |
Member
There was a problem hiding this comment.
This is certainly the shortest line of addition to implement the feature. But not necessarily the fastest to run. Note that the reduction in topi already supports negative index. So we don't need to handle negative index here, the only thing we need to handle is exclude, we can use another function GetExcludeAxes to get the other axes and return them as Array when there is exclude
tqchen
requested changes
Nov 22, 2018
|
|
||
| def _schedule_reduce(_, outs, target): | ||
| """Generic schedule for reduce""" | ||
| with tvm.target.create(target): |
Member
|
see the compute impl in #2163 that reflects the commend, the test-cases are still helpful and we would like to bring it in after 2163 |
18d772f to
82ae617
Compare
82ae617 to
96bdd3d
Compare
tqchen
approved these changes
Nov 26, 2018
Member
|
Thanks @siju-samuel @jroesch this is merged |
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2051
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.