Skip to content

[Relay] visit span#2015

Merged
tqchen merged 1 commit intoapache:masterfrom
MarisaKirisame:small-fix
Oct 28, 2018
Merged

[Relay] visit span#2015
tqchen merged 1 commit intoapache:masterfrom
MarisaKirisame:small-fix

Conversation

@MarisaKirisame
Copy link
Copy Markdown
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@tqchen
Copy link
Copy Markdown
Member

tqchen commented Oct 27, 2018

Thanks @MarisaKirisame

@tqchen tqchen added the status: need update need update based on feedbacks label Oct 27, 2018
@tqchen tqchen merged commit 26ceaac into apache:master Oct 28, 2018
@tqchen tqchen added status: accepted and removed status: need update need update based on feedbacks labels Oct 28, 2018
@MarisaKirisame
Copy link
Copy Markdown
Contributor Author

Am I supposed to add regression test? I am just coding features and decide to do them later.
Do you still want me to add them?

@tqchen
Copy link
Copy Markdown
Member

tqchen commented Oct 28, 2018

Since this change is obviously a correct one. I decided to merge this in for now. But we do need to ensure test coverages for most cases

eqy pushed a commit to eqy/tvm that referenced this pull request Oct 29, 2018
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
@MarisaKirisame MarisaKirisame deleted the small-fix branch March 28, 2019 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants