initialize base class in copy constructors#2006
Merged
tqchen merged 1 commit intoapache:masterfrom Oct 26, 2018
Merged
Conversation
GCC issues warnings with -Wextra if we don't explicitly initialize base class in copy constructors. This commit fixed the issue.
Contributor
Author
|
I am not sure who would be a right reviewer for this change. I am pinging @tqchen for taking a look at it. Thanks! |
tqchen
approved these changes
Oct 26, 2018
eqy
pushed a commit
to eqy/tvm
that referenced
this pull request
Oct 29, 2018
GCC issues warnings with -Wextra if we don't explicitly initialize base class in copy constructors. This commit fixed the issue.
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
GCC issues warnings with -Wextra if we don't explicitly initialize base class in copy constructors. This commit fixed the issue.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
GCC issues warnings with -Wextra if we don't explicitly initialize base class in copy constructors. This commit fixed the issue.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
GCC issues warnings with -Wextra if we don't explicitly initialize base class in copy constructors. This commit fixed the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC issues warnings with -Wextra if we don't explicitly initialize
base class in copy constructors. This commit fixed the issue.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.