Check iter_type in vectorize#1921
Merged
tqchen merged 1 commit intoapache:masterfrom Oct 19, 2018
izgzhen:check-vectorized-disallow
Merged
Check iter_type in vectorize#1921tqchen merged 1 commit intoapache:masterfrom izgzhen:check-vectorized-disallow
tqchen merged 1 commit intoapache:masterfrom
izgzhen:check-vectorized-disallow
Conversation
wweic
reviewed
Oct 18, 2018
wweic
left a comment
wweic
left a comment
There was a problem hiding this comment.
It's recommended to add test-cases to cover the new features or bugfix the patch introduces. So probably add a unit test(probably in test_lang_schedule.py) to make sure exception is correctly thrown, like https://github.com/dmlc/tvm/blob/dc996e451a3fee9dffefc31b652b6e85a72cb041/tests/python/unittest/test_pass_split_host_device.py#L4-L14
Member
|
Thanks for the contribution! please add a test case as @wweic suggested |
Contributor
Author
Member
tqchen
added
status: accepted
and removed
status: need update
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1795