[BUG] Fix incorrect libcuda.so found by cmake when multiple versions of CUDA exist#1788
Merged
tqchen merged 3 commits intoapache:masterfrom Oct 1, 2018
junrushao:fix-cmake
Merged
[BUG] Fix incorrect libcuda.so found by cmake when multiple versions of CUDA exist#1788tqchen merged 3 commits intoapache:masterfrom junrushao:fix-cmake
tqchen merged 3 commits intoapache:masterfrom
junrushao:fix-cmake
Conversation
Member
Author
|
Re-triggering the CI: test_topi_matmul.test_matmul is flaky (See http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-1788/1/pipeline). Related issue: #1784 |
Member
Author
|
A side note: It is undefined behavior to I noticed that this problem occurs every time when CI fails, so is it intended to return an undefined error code? |
Member
Author
|
@tqchen Could you help review this? Thanks! |
tqchen
approved these changes
Oct 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a very minor fix and a modification in cmake.
NO_DEFAULT_PATHwhen CUDA path is found. This particularly resolves my issue when building on the server in my university: when multiple CUDA versions exist, the originalFindCUDA.cmakecould possibly use incorrectlibcuda.so.I posted details of this issue on the TVM forum: https://discuss.tvm.ai/t/incorrect-libcuda-so-when-multiple-versions-of-cuda-exist-problem-and-solution/886.