[FRONTEND][ONNX]Gather operator added which is required for seq2seq models#1513
Merged
tqchen merged 1 commit intoapache:masterfrom Aug 1, 2018
Merged
[FRONTEND][ONNX]Gather operator added which is required for seq2seq models#1513tqchen merged 1 commit intoapache:masterfrom
tqchen merged 1 commit intoapache:masterfrom
Conversation
tqchen
approved these changes
Aug 1, 2018
|
Tried test out a simple RNN *.onnx model exported from PyTorch which makes use of Gather() and noticed in the Happy to provide the *.onnx model if requested, though for now here's a screenshot of relevant parts of the model containing the arguments passed to the Gather() opereator.
|
Contributor
|
I think ONNX supports Gather in 2 variations. I have created #1536 to followup and fix it. |
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.