Skip to content

[Unity]Lazy transform param now only work on non-dataflow block#14864

Merged
tqchen merged 1 commit intoapache:unityfrom
jinhongyii:lazy-transform-param-non-dataflow
May 17, 2023
Merged

[Unity]Lazy transform param now only work on non-dataflow block#14864
tqchen merged 1 commit intoapache:unityfrom
jinhongyii:lazy-transform-param-non-dataflow

Conversation

@jinhongyii
Copy link
Copy Markdown
Contributor

As #14829 mentioned, set_item is an impure function, so LazyTransformParam Pass should be done after manually applyiyng ToNonDataflow pass. This PR corrects the behavior.

cc: @slyubomirsky

@tvm-bot
Copy link
Copy Markdown
Collaborator

tvm-bot commented May 16, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@jinhongyii
Copy link
Copy Markdown
Contributor Author

@tqchen

@slyubomirsky
Copy link
Copy Markdown
Contributor

Thank you for making the change :)

@slyubomirsky slyubomirsky mentioned this pull request May 18, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants