Skip to content

[Unity][CODEGEN] Fix metal codegen when with only single working dim#14627

Merged
junrushao merged 1 commit intoapache:unityfrom
tqchen:metal
Apr 14, 2023
Merged

[Unity][CODEGEN] Fix metal codegen when with only single working dim#14627
junrushao merged 1 commit intoapache:unityfrom
tqchen:metal

Conversation

@tqchen
Copy link
Copy Markdown
Member

@tqchen tqchen commented Apr 14, 2023

This PR fixes the metal introduces by a previous commit that removes the workdim remapping that caused issues for kernels with only threadIdx.x and blockIdx.x

@tvm-bot
Copy link
Copy Markdown
Collaborator

tvm-bot commented Apr 14, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@tqchen
Copy link
Copy Markdown
Member Author

tqchen commented Apr 14, 2023

cc @Lunderberg was caused by recent merging that bought in #14495 . This is a hotfix, will also need pick to main

This PR fixes the metal introduces by a previous commit that removes
the workdim remapping that caused issues for kernels with only threadIdx.x
and blockIdx.x
@junrushao junrushao merged commit 93945ce into apache:unity Apr 14, 2023
tqchen added a commit to tqchen/tvm that referenced this pull request Apr 17, 2023
…pache#14627)

[CODEGEN] Fix metal codegen when with only single working dim

This PR fixes the metal introduces by a previous commit that removes
the workdim remapping that caused issues for kernels with only threadIdx.x
and blockIdx.x
@Lunderberg
Copy link
Copy Markdown
Contributor

Thank you for finding the fix, and that makes sense with the different naming based on the number of block/thread dimensions. Do we have any tests of the metal codegen in CI? I was hoping to add a test to catch this failure, but it looks like Metal doesn't currently run on the CI due to being OSX-only.

@tqchen
Copy link
Copy Markdown
Member Author

tqchen commented Apr 17, 2023

right i think it should be covered by tests already but was not run due to metal being osx only

tqchen added a commit to tqchen/tvm that referenced this pull request Apr 19, 2023
…pache#14627)

[CODEGEN] Fix metal codegen when with only single working dim

This PR fixes the metal introduces by a previous commit that removes
the workdim remapping that caused issues for kernels with only threadIdx.x
and blockIdx.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants