[ARITH] Enhance IterMapSimplify for symbolic #14547
Merged
junrushao merged 3 commits intoapache:mainfrom Apr 12, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Member
Author
|
depends on #14538 |
tqchen
force-pushed
the
iter-arith
branch
4 times, most recently
from
eb0dfdf to
f422a7c
Compare
tqchen
force-pushed
the
iter-arith
branch
4 times, most recently
from
dcd1ef9 to
e767073
Compare
tqchen
changed the title
tqchen
changed the title
junrushao
approved these changes
Apr 11, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Very cool. Let's get it in!
tqchen
force-pushed
the
iter-arith
branch
3 times, most recently
from
0c98816 to
385e190
Compare
Member
|
This PR should be good to go as #14571 has been merged |
This PR refactors and enhances DetectIterMap and IterMapSimplify to enable symbolic shape simplification. Specifically, we add a routine to combine multiple IterSplitExpr into one if they come from the same source. It is helpful to distinguish iterator from normal constants in the simplification process. IterMapSimplify takes advantage of these information. This improvements is helpful to simplify the indices in flattened buffer when there is symbolic shape involved and normal simplifier. Also updated FlattenBuffer to take benefit of the enhanced simplifier. Test cases are added.
ordering and simplifcations. Co-authored-by: Junru Shao <junrushao@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors and enhances DetectIterMap and IterMapSimplify
to enable symbolic shape simplification. Specficially, we add
a routine to combine multiple IterSplitExpr into one if they
come from the same source.
It is helpful to distinguish iterator from normal constants
in the simplification process. IterMapSimplify takes advantage
of these information.
This improvements is helpful to simplify the indices in flattened buffer
when there is symbolic shape involved and normal simplifier.
Also updated FlattenBuffer to take benefit of the enhanced simplifier.
Test cases are added.