[Unity] Support Simple Dynamic-Shape-Aware in FuseTIR#14515
Merged
Hzfengsy merged 2 commits intoapache:unityfrom Apr 6, 2023
Merged
[Unity] Support Simple Dynamic-Shape-Aware in FuseTIR#14515Hzfengsy merged 2 commits intoapache:unityfrom
Hzfengsy merged 2 commits intoapache:unityfrom
Conversation
In the last PR apache#14396, we enable dynamic-shape-aware fusion in FuseOps. In this PR, we support the following FuseTIR pass for simple cases. This PR also fixes a minor compilation warning in `json_runtime.h`
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
approved these changes
Apr 6, 2023
MasterJH5574
requested changes
Apr 6, 2023
Contributor
MasterJH5574
left a comment
MasterJH5574
left a comment
There was a problem hiding this comment.
Caught an issue here: https://gist.github.com/MasterJH5574/01faf389cecd4718a1f7f7129343ec3a
Not hard to fix. Personally touched base with @Hzfengsy, and we will fix this issue within this PR. Requesting change to prevent immature merge.
Member
Author
|
@MasterJH5574 Fixed, please take another look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the last PR #14396, we enable dynamic-shape-aware fusion in FuseOps. In this PR, we support the following FuseTIR pass for simple cases.
This PR also fixes a minor compilation warning in
json_runtime.hcc @tqchen @MasterJH5574