[LLVM] Add missing override to GetFormat and GetPropertyMask#14470
Merged
tqchen merged 1 commit intoapache:mainfrom Apr 5, 2023
Merged
[LLVM] Add missing override to GetFormat and GetPropertyMask#14470tqchen merged 1 commit intoapache:mainfrom
override to GetFormat and GetPropertyMask#14470tqchen merged 1 commit intoapache:mainfrom
Conversation
These functions are virtual, and some of the overrides were not marked as either `final` or `override` causing compilation warnings.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
The CPU build failure is due to |
Member
|
We can temp disable rust tests to unlock CI |
Member
|
@tvm-bot rerun |
tqchen
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions are virtual, and some of the overrides were not marked as either
finaloroverridecausing compilation warnings.