[relay] preserve the order of input_info of pytorch#14462
[relay] preserve the order of input_info of pytorch#14462masahi merged 4 commits intoapache:mainfrom
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
5750245 to
eb75592
Compare
|
I fixed lint. please re-review. |
|
Some tests are broken, please fix them. |
6120407 to
67cde54
Compare
67cde54 to
5bae5f3
Compare
|
@masahi I fixed a test failure. However, I cannot interpret the current test results. I checked https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-minimal-cross-isa/detail/PR-14462/6/pipeline/95 but what i see is |
|
@tvm-bot rerun |
|
@masahi Could you run again please? (or can i do it myself?) |
|
@tvm-bot rerun |
|
@masahi Now all checks have passed. |
This is for resolving #14461
The direct cause of this problem is that the order of input nodes found in
_analysis.free_vars(ret)is not guaranteed in the order of names ininput_info. From what I understand,_analysis.free_vars(ret)uses DFS to find input nodes from output nodes. Since DFS cannot guarantee the order in which nodes are found, it is intuitive to modify the order of input nodes after DFS, as shown in this PR.