Skip to content

[relay][frontend][pytorch]Fix a bug in the _get_pytorch_value_type function#14421

Merged
masahi merged 2 commits intoapache:mainfrom
hfliuyun:fix_relay_pytorch
Mar 30, 2023
Merged

[relay][frontend][pytorch]Fix a bug in the _get_pytorch_value_type function#14421
masahi merged 2 commits intoapache:mainfrom
hfliuyun:fix_relay_pytorch

Conversation

@hfliuyun
Copy link
Copy Markdown
Contributor

@hfliuyun hfliuyun commented Mar 29, 2023

Fixed a bug in _get_pytorch_value_type(): kind should be used to determine if it is an OptionalType, instead of pt_dtype

@tvm-bot
Copy link
Copy Markdown
Collaborator

tvm-bot commented Mar 29, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@masahi
Copy link
Copy Markdown
Member

masahi commented Mar 29, 2023

Thanks, please fix lint.

@hfliuyun
Copy link
Copy Markdown
Contributor Author

hfliuyun commented Mar 29, 2023

@masahi I have have corrected the lint.

@masahi
Copy link
Copy Markdown
Member

masahi commented Mar 29, 2023

@tvm-bot rerun

@masahi masahi merged commit 9f6ce7c into apache:main Mar 30, 2023
@hfliuyun hfliuyun deleted the fix_relay_pytorch branch March 31, 2023 05:31
@ysh329 ysh329 mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masahi masahi masahi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hfliuyun @tvm-bot @masahi