[Unity][Fix] Annotate TIR op pattern could have no stores.#14420
Merged
masahi merged 2 commits intoapache:unityfrom Mar 29, 2023
Merged
[Unity][Fix] Annotate TIR op pattern could have no stores.#14420masahi merged 2 commits intoapache:unityfrom
masahi merged 2 commits intoapache:unityfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
sunggg
reviewed
Mar 29, 2023
39aabb0 to
7394af5
Compare
Contributor
Author
added a test and some context. |
sunggg
approved these changes
Mar 29, 2023
tqchen
pushed a commit
that referenced
this pull request
Apr 1, 2023
* [Unity][Fix] Annotate TIR op pattern could have no stores. * Add test case for context
tqchen
pushed a commit
that referenced
this pull request
Apr 1, 2023
* [Unity][Fix] Annotate TIR op pattern could have no stores. * Add test case for context
tqchen
pushed a commit
that referenced
this pull request
Apr 1, 2023
* [Unity][Fix] Annotate TIR op pattern could have no stores. * Add test case for context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where a block could have no stores, the pass crashes in such a case. We should mark the PrimFunc as opaque in such a case.
This happens if instead of using buffer load/stores we use
tir.call_packedfor computation.cc @jwfromm @sunggg