[Unity][TVMScript] Fix Shape Var occurrence in Tensor annotation#14404
Merged
tqchen merged 2 commits intoapache:unityfrom Mar 26, 2023
Merged
[Unity][TVMScript] Fix Shape Var occurrence in Tensor annotation#14404tqchen merged 2 commits intoapache:unityfrom
tqchen merged 2 commits intoapache:unityfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
tqchen
approved these changes
Mar 26, 2023
Hzfengsy
approved these changes
Mar 26, 2023
farshidsp
pushed a commit
to farshidsp/tvm
that referenced
this pull request
Mar 27, 2023
…che#14404) This PR enables relax parser to handle Var with ShapeExpr value occuring in R.Tensor annotations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the script reports error
because the relax parser cannot handle Var with ShapeExpr value occuring in R.Tensor annotations.
This PR specifically checks such cases in parser.
Thanks to the observation from @SiriusNEO
cc @Hzfengsy @tqchen