[TIR] Update LowerTVMBuiltin to use Optional<T>#14400
Merged
masahi merged 1 commit intoapache:mainfrom Mar 30, 2023
Merged
Conversation
The member variables `device_type_` and `device_id_` are tracked during `LowerTVMBuiltin`, are initially undefined, and are checked before use. This is the usage pattern expected for `Optional<T>`, but these variables previously had the type `PrimExpr`. This commit updates these to `Optional<PrimExpr>`, and uses the helper function `GetDeviceMethodName` to add more detail to the error messages when they are undefined.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
|
@tvm-bot rerun |
masahi
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The member variables
device_type_anddevice_id_are tracked duringLowerTVMBuiltin, are initially undefined, and are checked before use. This is the usage pattern expected forOptional<T>, but these variables previously had the typePrimExpr.This commit updates these to
Optional<PrimExpr>, and uses the helper functionGetDeviceMethodNameto add more detail to the error messages when they are undefined.