[TVMScript][Fix] Fix bool printing for roundtrip#14390
Merged
MasterJH5574 merged 3 commits intoapache:mainfrom Mar 24, 2023
Merged
[TVMScript][Fix] Fix bool printing for roundtrip#14390MasterJH5574 merged 3 commits intoapache:mainfrom
bool printing for roundtrip#14390MasterJH5574 merged 3 commits intoapache:mainfrom
Conversation
This PR fixes the TVMScript printer to print `T.bool(True)` or `T.bool(False)` for `IntImm(dtype=bool)`. So the parser is able to parse it back.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
zxybazh
approved these changes
Mar 23, 2023
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
Thanks for the quick fix, LGTM!
MasterJH5574
approved these changes
Mar 24, 2023
Hzfengsy
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the TVMScript printer to print
T.bool(True)orT.bool(False)forIntImm(dtype=bool). So the parser is able to parse it back.