[Analysis] Improve error message in VerifyWellFormed#14389
Merged
masahi merged 1 commit intoapache:mainfrom Mar 30, 2023
Merged
[Analysis] Improve error message in VerifyWellFormed#14389masahi merged 1 commit intoapache:mainfrom
masahi merged 1 commit intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Member
|
Thanks @Lunderberg for the improvement. BTW, could you please send this PR to |
Previously, the error message gave the name of the variable that should not be used within the current block. This commit updates the error message to also state where that variable was defined, and which block contains the erroneous use of the variable.
Lunderberg
force-pushed
the
unity_well_formed_error_message
branch
from
3162551 to
badfbce
Compare
Lunderberg
changed the title
Contributor
Author
|
Thank you for the catch, and the PR is now rebased onto main, and set to merge into main instead of unity. |
Hzfengsy
approved these changes
Mar 24, 2023
Contributor
Author
|
@tvm-bot rerun |
1 similar comment
Contributor
Author
|
@tvm-bot rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the error message gave the name of the variable that should not be used within the current block. This commit updates the error message to also state where that variable was defined, and which block contains the erroneous use of the variable.