[TOPI] Fix data race of batch multibox detection#14343
Merged
masahi merged 4 commits intoapache:mainfrom Apr 7, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
@tvm-bot rerun |
Contributor
Author
|
cc @kevinthesun @Laurawly @tqchen Hi~ could you kindly take a look at it, thanks! |
Member
|
cc @masahi , can you help to take a look at this? |
masahi
approved these changes
Apr 4, 2023
| box_coord[l] = anchor[0, j, l] | ||
| pred_coord[l] = loc_pred[i, j * 4 + l] | ||
| out_coord = _hybridy_transform_loc(box_coord, pred_coord, variances, clip) | ||
| box_coord[i, l] = anchor[0, j, l] |
Member
There was a problem hiding this comment.
It seems box_coord is the same in all threads. How about passing anchor, j, and l to _hybridy_transform_loc instead?
Contributor
Author
There was a problem hiding this comment.
good idea~ updated as suggested.
Member
|
Need to fix lint. |
Member
|
@tvm-bot rerun |
1 similar comment
Contributor
Author
|
@tvm-bot rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
box_coordandpred_coordis shared across parallel batch like