[CODEGEN][METAL] Fix unaligned vector load#14332
Merged
MasterJH5574 merged 1 commit intoapache:mainfrom Mar 20, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
junrushao
approved these changes
Mar 19, 2023
MasterJH5574
approved these changes
Mar 19, 2023
spectrometerHBH
approved these changes
Mar 19, 2023
Contributor
spectrometerHBH
left a comment
spectrometerHBH
left a comment
There was a problem hiding this comment.
Shall we somehow examine the output C source code is as expected?
Member
Author
|
I have thought a bit about it in the end feel test correctness coverage is better in this case if we want future edits. We can indeed followup with source checking if new related regression arises |
Member
|
it seems that this patch breaks OpenCL/Vulkan codegen tests.. |
Member
Author
|
interesting, will dig a bit. |
Member
Author
|
seems that |
This PR fixes the implementation of unaligned vector load. Previously vector construction was printed as (float2)(v0, v1). This will cause problem as C have comma expression, and (v0, v1) will be evaluated as v1. The final result will become float2(v1, v1). The bug affects all codegen that uses the default implementation, such as metal. We added a testcase on metal to cover this case. Also updated codegen opencl to keep the old style as that is the convention opencl follows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the implementation of unaligned vector load. Previously vector construction was printed as (float2)(v0, v1). This will cause problem as C have comma expression, and (v0, v1) will be evaluated as v1. The final result will become float2(v1, v1). The bug affects all codegen that uses the default implementation, such as metal. We added a testcase on metal to cover this case.