[Relay][Op] Connect existing arm_cpu schedule to relay strategy for concat#14270
Merged
lhutton1 merged 2 commits intoapache:mainfrom Mar 14, 2023
Merged
[Relay][Op] Connect existing arm_cpu schedule to relay strategy for concat#14270lhutton1 merged 2 commits intoapache:mainfrom
lhutton1 merged 2 commits intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
asparkhi
force-pushed
the
concat_arm_cpu
branch
from
6183c1f to
32dcf73
Compare
asparkhi
changed the title
lhutton1
reviewed
Mar 13, 2023
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Nice catch @ashutosh-arm! Just one small nit about the test location..
…atenate NPU used generic implementation for concatenate before cpu schedules were made the default fallback schedules. This leads to performance degradation as this blocks fusion with nearby ops. This commit adds Relay op strategy for arm_cpu implementation which makes it use arm_cpu schedule before cpu one. Reference: apache#13775 Co-authored-by: Luke Hutton <luke.hutton@arm.com>
asparkhi
force-pushed
the
concat_arm_cpu
branch
from
32dcf73 to
c80d8fa
Compare
Change-Id: Ic29488d2ba25acfdccbb6cdab1697eec9ae3a736
lhutton1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPU used generic implementation for concatenate
before cpu schedules were made the default fallback
schedules. This leads to performance degradation
as this blocks fusion with nearby ops. This commit
adds Relay op strategy for arm_cpu implementation
which makes it use arm_cpu schedule before cpu one.
Reference: #13775
cc @lhutton1