[Utils] Allow classmethod and staticmethod in TVMDerivedObject#14249
Merged
junrushao merged 2 commits intoapache:mainfrom Mar 13, 2023
Merged
[Utils] Allow classmethod and staticmethod in TVMDerivedObject#14249junrushao merged 2 commits intoapache:mainfrom
junrushao merged 2 commits intoapache:mainfrom
Conversation
Instance methods that exist in the user-defined class but not in the TVM base are forward using `__getattr__`. However, this is only applied for attribute look of instances, and doesn't apply for attribute lookup on the class object itself, such as when calling a classmethod or staticmethod. This commit exposes class methods and static methods in the wrapper class, if they are defined in the user-defined subclass.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
approved these changes
Mar 13, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
LGTM! Thanks for enhancing the utility!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instance methods that exist in the user-defined class but not in the TVM base are forward using
__getattr__. However, this is only applied for attribute look of instances, and doesn't apply for attribute lookup on the class object itself, such as when calling a classmethod or staticmethod.This commit exposes class methods and static methods in the wrapper class, if they are defined in the user-defined subclass.