[TVMScript] Distinguish LetStmt and Let expression#14207
Merged
zxybazh merged 1 commit intoapache:mainfrom Mar 6, 2023
Merged
Conversation
Collaborator
167e7d7 to
db4bc0b
Compare
As the legacy behavior of previous generation of TVMScript printer,
LetStmt and Let expression in TIR are printed in the same syntax, i.e.
`T.let`. This could be confusing and misleading at times.
This PR introduces a new printer behavior in a backward compatible way.
While ensuring all legacy `T.let` can be parsed properly, we introduce
different syntax for each of them.
For LetStmt in TIR without concise scoping, the new syntax is:
```python
with T.LetStmt(value) as var:
...
```
which was:
```python
var = T.int32()
with T.let(var, value):
...
```
For let expression in TIR PrimExpr, the new syntax becomes:
```python
x = T.int32()
T.Let(x + 1, where={x : 1})
```
which was:
```python
x = T.int32()
T.let(x, 1, x + 1)
```
db4bc0b to
488eaed
Compare
spectrometerHBH
approved these changes
Mar 6, 2023
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Mar 16, 2023
When the TVMScript parser generates a `tir::LetStmt` to represent assignment to a variable, the name of the variable should be used as the name of the `tir::Var` in the `tir::LetStmt`. This bug was introduced in apache#14207.
junrushao
pushed a commit
that referenced
this pull request
Mar 17, 2023
When the TVMScript parser generates a `tir::LetStmt` to represent assignment to a variable, the name of the variable should be used as the name of the `tir::Var` in the `tir::LetStmt`. This bug was introduced in #14207.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the legacy behavior of previous generation of TVMScript printer, LetStmt and Let expression in TIR are printed in the same syntax, i.e.
T.let. This could be confusing and misleading at times.This PR introduces a new printer behavior in a backward compatible way. While ensuring all legacy
T.letcan be parsed properly, we introduce different syntax for each of them.For LetStmt in TIR without concise scoping, the new syntax is:
which was:
For let expression in TIR PrimExpr, the new syntax becomes:
which was: